Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Limit the speed of the generating stats task #39644

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xiaocai2333
Copy link
Contributor

No description provided.

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xiaocai2333
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Feb 5, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Feb 5, 2025
Copy link
Contributor

mergify bot commented Feb 5, 2025

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.14%. Comparing base (13cffaf) to head (c78d3a6).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
internal/datacoord/job_manager.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39644       +/-   ##
===========================================
+ Coverage   69.39%   80.14%   +10.74%     
===========================================
  Files         302     1476     +1174     
  Lines       27077   204392   +177315     
===========================================
+ Hits        18790   163802   +145012     
- Misses       8287    34740    +26453     
- Partials        0     5850     +5850     
Components Coverage Δ
Client 79.44% <ø> (∅)
Core 69.39% <ø> (ø)
Go 81.87% <87.50%> (∅)
Files with missing lines Coverage Δ
internal/datacoord/task_scheduler.go 95.84% <100.00%> (ø)
pkg/util/paramtable/component_param.go 98.29% <100.00%> (ø)
internal/datacoord/job_manager.go 75.78% <0.00%> (ø)

... and 1171 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Feb 5, 2025

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333 xiaocai2333 force-pushed the limit_stats_task_generate branch from 15571fc to 38b9145 Compare February 7, 2025 01:51
Copy link
Contributor

mergify bot commented Feb 7, 2025

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 7, 2025

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333 xiaocai2333 force-pushed the limit_stats_task_generate branch from 38b9145 to 251f86d Compare February 8, 2025 03:31
Copy link
Contributor

mergify bot commented Feb 8, 2025

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Feb 8, 2025

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@xiaocai2333 xiaocai2333 force-pushed the limit_stats_task_generate branch from 251f86d to c78d3a6 Compare February 10, 2025 07:35
@mergify mergify bot added the ci-passed label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants