fix: Remove getModTime() to use ModTime() from os.FileInfo directly

[Gofastasf]

• Use ModTime from os.FileInfo directly instead of custom getModTime implementation.
• Removed test case for getModTime().

Signed-off-by: Gofastasf [email protected]

[sre-ci-robot]

Welcome @Gofastasf! It looks like this is your first PR to milvus-io/milvus 🎉

[sre-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Gofastasf
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• internal/storage/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mergify]

@Gofastasf Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

[mergify]

@Gofastasf Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

[mergify]

@Gofastasf go-sdk check failed, comment rerun go-sdk can trigger the job again.

[mergify]

@Gofastasf E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

[mergify]

@Gofastasf go-sdk check failed, comment rerun go-sdk can trigger the job again.

[Gofastasf]

/run-cpu-e2e

[Gofastasf]

rerun go-sdk

[mergify]

@Gofastasf E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

[mergify]

@Gofastasf go-sdk check failed, comment rerun go-sdk can trigger the job again.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.40%. Comparing base (b3791a6) to head (3d0feea).

❌ Your project check has failed because the head coverage (69.40%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (b3791a6) and HEAD (3d0feea). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (b3791a6)	HEAD (3d0feea)
	2	1

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #39623       +/-   ##
===========================================
- Coverage   80.14%   69.40%   -10.74%     
===========================================
  Files        1465      302     -1163     
  Lines      203091    27065   -176026     
===========================================
- Hits       162762    18785   -143977     
+ Misses      34526     8280    -26246     
+ Partials     5803        0     -5803     

Components	Coverage Δ
Client	∅ <ø> (∅)
Core	69.40% <ø> (ø)
Go	∅ <ø> (∅)

see 1163 files with indirect coverage changes

[mergify]

@Gofastasf go-sdk check failed, comment rerun go-sdk can trigger the job again.

[mergify]

@Gofastasf E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

[xiaofan-luan]

hi @Gofastasf
any reason to make this change or it's simply cleanup the code?

[Gofastasf]

@xiaofan-luan
To reduce redundant Stat call.
filepath.Walk already has os.FileInfo which has ModTime. So directly use it from there instead of extra function call.

[xiaofan-luan]

The pr overall looks good to me.
We need a related issue and seems that the e2e cluster has some issue and we need to fix that

[mergify]

@Gofastasf E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.