Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: broadcast with event-based notification #39550

Open
wants to merge 3 commits into
base: 2.5
Choose a base branch
from

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Jan 23, 2025

issue: #38399
pr: #39522

  • broadcast message can carry multi resource key now.
  • implement event-based notification for broadcast messages
  • broadcast message use broadcast id as a unique identifier in message
  • broadcasted message on vchannels keep the broadcasted vchannel now.
  • broadcasted message and broadcast message have a common broadcast header now.

- broadcast message can carry multi resource key now.
- implement event-based notification for broadcast messages
- broadcast message use broadcast id as a unique identifier in message
- broadcasted message on vchannels keep the broadcasted vchannel now.
- broadcasted message and broadcast message have a common broadcast
  header now.

Signed-off-by: chyezh <[email protected]>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chyezh
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Jan 23, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 23, 2025
Copy link
Contributor

mergify bot commented Jan 23, 2025

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@chyezh chyezh force-pushed the enhance_broadcast_with_resource_lock_2_5 branch from b61652f to 7c9ec9a Compare January 23, 2025 09:45
Signed-off-by: chyezh <[email protected]>
@chyezh chyezh force-pushed the enhance_broadcast_with_resource_lock_2_5 branch from 7c9ec9a to 4ae22b5 Compare January 23, 2025 09:50
Copy link
Contributor

mergify bot commented Jan 23, 2025

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 23, 2025

@chyezh cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Jan 23, 2025

rerun cpp-unit-test

@chyezh
Copy link
Contributor Author

chyezh commented Jan 23, 2025

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 23, 2025

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 87.05502% with 120 lines in your changes missing coverage. Please review.

Project coverage is 81.07%. Comparing base (6cdabd9) to head (c8502dd).
Report is 6 commits behind head on 2.5.

Files with missing lines Patch % Lines
...nternal/streamingcoord/server/service/broadcast.go 23.33% 21 Missing and 2 partials ⚠️
pkg/streaming/util/message/message_impl.go 44.44% 11 Missing and 9 partials ⚠️
...al/streamingcoord/client/broadcast/grpc_watcher.go 85.03% 16 Missing and 3 partials ⚠️
...treamingcoord/client/broadcast/watcher_resuming.go 90.19% 9 Missing and 1 partial ⚠️
...amingcoord/server/broadcaster/broadcast_manager.go 92.50% 6 Missing and 3 partials ⚠️
...server/service/broadcast/broadcast_watch_server.go 88.05% 6 Missing and 2 partials ⚠️
pkg/streaming/util/message/broadcast.go 88.52% 6 Missing and 1 partial ⚠️
...ernal/streamingcoord/server/broadcaster/watcher.go 90.32% 6 Missing ⚠️
pkg/log/with_logger.go 44.44% 3 Missing and 2 partials ⚠️
pkg/streaming/util/message/builder.go 66.66% 1 Missing and 3 partials ⚠️
... and 4 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #39550      +/-   ##
==========================================
+ Coverage   80.97%   81.07%   +0.10%     
==========================================
  Files        1404     1415      +11     
  Lines      198032   198827     +795     
==========================================
+ Hits       160347   161197     +850     
+ Misses      32037    31978      -59     
- Partials     5648     5652       +4     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.48% <ø> (ø)
Go 83.04% <86.82%> (+0.11%) ⬆️
Files with missing lines Coverage Δ
internal/coordinator/coordclient/registry.go 91.17% <ø> (-1.04%) ⬇️
internal/distributed/streaming/append.go 74.19% <ø> (-2.95%) ⬇️
internal/distributed/streaming/broadcast.go 100.00% <100.00%> (ø)
internal/distributed/streaming/streaming.go 100.00% <ø> (ø)
internal/distributed/streaming/wal.go 64.22% <100.00%> (-1.87%) ⬇️
internal/metastore/catalog.go 100.00% <ø> (ø)
internal/metastore/kv/streamingcoord/kv_catalog.go 79.31% <100.00%> (ø)
internal/rootcoord/broadcast_task.go 9.61% <ø> (+0.84%) ⬆️
internal/streamingcoord/client/client.go 97.01% <100.00%> (ø)
internal/streamingcoord/client/client_impl.go 81.81% <100.00%> (+1.81%) ⬆️
... and 24 more

... and 51 files with indirect coverage changes

@chyezh
Copy link
Contributor Author

chyezh commented Jan 23, 2025

rerun ut

@chyezh
Copy link
Contributor Author

chyezh commented Jan 23, 2025

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 23, 2025

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@chyezh chyezh force-pushed the enhance_broadcast_with_resource_lock_2_5 branch from 50458ea to a878bf4 Compare January 23, 2025 14:58
@chyezh
Copy link
Contributor Author

chyezh commented Jan 24, 2025

rerun ut

@chyezh chyezh force-pushed the enhance_broadcast_with_resource_lock_2_5 branch from a878bf4 to c8502dd Compare January 25, 2025 04:02
Copy link
Contributor

mergify bot commented Jan 25, 2025

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Jan 25, 2025

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/internal-api area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement sig/testing size/XXL Denotes a PR that changes 1000+ lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants