Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adjust segment loader's memory estimate for intermin indexes #39507

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Adjust segment loader's memory estimate for intermin indexes #39507

wants to merge 1 commit into from

Conversation

cqy123456
Copy link
Contributor

@cqy123456 cqy123456 commented Jan 22, 2025 •
edited
Loading

issue: #27678
related 2.4 pr: #39508
related 2.5 pr: #39509
related master pr: #39507

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jan 22, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 22, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 22, 2025

@cqy123456 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

This was referenced Jan 22, 2025
Merged
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 22, 2025

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 22, 2025

@cqy123456 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@cqy123456
Copy link
Contributor Author

/run-cpu-e2e

@cqy123456
Copy link
Contributor Author

rerun go-sdk

@codecov Codecov
Copy link

codecov bot commented Jan 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.72%. Comparing base (05ac404) to head (db2ecaf).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39507       +/-   ##
===========================================
+ Coverage   69.40%   81.72%   +12.32%     
===========================================
  Files         302     1163      +861     
  Lines       27065   176089   +149024     
===========================================
+ Hits        18785   143916   +125131     
- Misses       8280    26351    +18071     
- Partials        0     5822     +5822
Components Coverage Δ
Client 79.45% <ø> (∅)
Core ∅ <ø> (∅)
Go 81.82% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/querynodev2/segments/segment_loader.go 71.02% <100.00%> (ø)

... and 1464 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 22, 2025

@cqy123456 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@cqy123456
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 22, 2025

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@cqy123456 cqy123456 force-pushed the interim-index-mem-master branch from dd3e1a8 to 8a05294 Compare January 23, 2025 02:46
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 23, 2025

@cqy123456 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 23, 2025

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@cqy123456
Copy link
Contributor Author

/run-cpu-e2e

1 similar comment
@cqy123456
Copy link
Contributor Author

/run-cpu-e2e

foxspy
foxspy approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@foxspy foxspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cqy123456, foxspy
To complete the pull request process, please assign tedxu after the PR has been reviewed.
You can assign the PR to them by writing /assign @tedxu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 23, 2025

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

sre-ci-robot pushed a commit that referenced this pull request Jan 24, 2025
@cqy123456
fix: [2.4]Adjust segment loader's memory estimate for intermin indexes (
9848606 
#39508)

issue: #27678
related 2.4 pr: #39508
related 2.5 pr: #39509
related master pr: #39507

Signed-off-by: cqy123456 <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request Jan 24, 2025
@cqy123456
fix: [2.5]Adjust segment loader's memory estimate for intermin indexes (
758ac5a 
#39509)

issue: #27678
related 2.4 pr: #39508
related 2.5 pr: #39509
related master pr: #39507

Signed-off-by: cqy123456 <[email protected]>
@cqy123456 cqy123456 force-pushed the interim-index-mem-master branch from 8a05294 to db2ecaf Compare February 5, 2025 08:06
@sre-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@sre-ci-robot sre-ci-robot removed the lgtm label Feb 5, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 5, 2025

@cqy123456 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 5, 2025

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 5, 2025

@cqy123456 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foxspy foxspy foxspy approved these changes

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@congqixia congqixia Awaiting requested review from congqixia

Assignees

@foxspy foxspy

Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cqy123456 @sre-ci-robot @foxspy