Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: remove compaction parallelism control (#39081) #39487

Open
wants to merge 1 commit into
base: 2.5
Choose a base branch
from

Conversation

czs007
Copy link
Collaborator

@czs007 czs007 commented Jan 21, 2025

issue : #39080
pr : #39081

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/L Denotes a PR that changes 100-499 lines. labels Jan 21, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 21, 2025
Copy link
Contributor

mergify bot commented Jan 21, 2025

@czs007 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@czs007
Copy link
Collaborator Author

czs007 commented Jan 21, 2025

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 21, 2025

@czs007 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 86.88525% with 8 lines in your changes missing coverage. Please review.

Project coverage is 80.99%. Comparing base (8475d8b) to head (e7211d6).

Files with missing lines Patch % Lines
internal/datacoord/compaction.go 86.44% 6 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #39487      +/-   ##
==========================================
- Coverage   80.99%   80.99%   -0.01%     
==========================================
  Files        1404     1404              
  Lines      197899   197876      -23     
==========================================
- Hits       160296   160262      -34     
- Misses      31980    31984       +4     
- Partials     5623     5630       +7     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.47% <ø> (ø)
Go 82.95% <86.88%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
pkg/util/paramtable/component_param.go 98.40% <100.00%> (+<0.01%) ⬆️
internal/datacoord/compaction.go 72.57% <86.44%> (+1.47%) ⬆️

... and 36 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants