Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] fix assignment operator in AssertInfo to comparison operator #39351

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

SpadeA-Tang
Copy link
Contributor

@SpadeA-Tang SpadeA-Tang commented Jan 16, 2025

cp #39347
issue: #39346

Signed-off-by: SpadeA-Tang <[email protected]>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 16, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 16, 2025
Copy link
Contributor

mergify bot commented Jan 16, 2025

@SpadeA-Tang Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@chasingegg
Copy link
Contributor

/lgtm

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.02%. Comparing base (9d2a0e7) to head (3b1b2c9).
Report is 5 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #39351      +/-   ##
==========================================
+ Coverage   81.01%   81.02%   +0.01%     
==========================================
  Files        1404     1404              
  Lines      197421   197420       -1     
==========================================
+ Hits       159939   159961      +22     
+ Misses      31847    31827      -20     
+ Partials     5635     5632       -3     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.52% <ø> (+0.01%) ⬆️
Go 82.99% <ø> (+0.01%) ⬆️
Files with missing lines Coverage Δ
...nal/core/src/exec/operator/IterativeFilterNode.cpp 76.33% <ø> (-0.18%) ⬇️

... and 24 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 16, 2025
@czs007
Copy link
Collaborator

czs007 commented Jan 17, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, SpadeA-Tang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 47e410f into milvus-io:2.5 Jan 17, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants