Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Upgrade go zstd to 1.5.6 #39311

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexanderguzhva
Copy link
Contributor

issue: #39175

@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. area/dependency Pull requests that update a dependency file labels Jan 15, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alexanderguzhva
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alexanderguzhva alexanderguzhva changed the title enhance: Upgrade zstd to 1.5.6 enhance: Upgrade go zstd to 1.5.6 Jan 15, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 15, 2025
Copy link
Contributor

mergify bot commented Jan 15, 2025

@alexanderguzhva go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.56%. Comparing base (e111c92) to head (3026440).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39311      +/-   ##
==========================================
- Coverage   69.58%   69.56%   -0.02%     
==========================================
  Files         300      300              
  Lines       26986    26986              
==========================================
- Hits        18777    18773       -4     
- Misses       8209     8213       +4     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.56% <ø> (-0.02%) ⬇️
Go ∅ <ø> (∅)

see 1 file with indirect coverage changes

@xiaofan-luan
Copy link
Collaborator

@alexanderguzhva
there seems to be some lint issues.
could you rebase with latest master and rerun the test?

@xiaofan-luan
Copy link
Collaborator

rerun go-sdk

Signed-off-by: Alexandr Guzhva <[email protected]>
Copy link
Contributor

mergify bot commented Jan 21, 2025

@alexanderguzhva go-sdk check failed, comment rerun go-sdk can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Pull requests that update a dependency file dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants