Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] enable to build index with single segment #39272

Merged
merged 5 commits into from
Jan 16, 2025

Conversation

SpadeA-Tang
Copy link
Contributor

@SpadeA-Tang SpadeA-Tang commented Jan 15, 2025

issue: #39232
cherry-pick #39233

Signed-off-by: SpadeA-Tang <[email protected]>
@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. area/compilation labels Jan 15, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 15, 2025
Copy link
Contributor

mergify bot commented Jan 15, 2025

@SpadeA-Tang Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link
Contributor

mergify bot commented Jan 15, 2025

@SpadeA-Tang cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 15, 2025

@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 15, 2025

@SpadeA-Tang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SpadeA-Tang
Copy link
Contributor Author

rerun cpp-unit-test

Signed-off-by: SpadeA-Tang <[email protected]>
Copy link
Contributor

mergify bot commented Jan 15, 2025

@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 81.05%. Comparing base (2439278) to head (d2891fc).
Report is 6 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/core/src/index/InvertedIndexTantivy.cpp 67.92% 17 Missing ⚠️
internal/core/src/indexbuilder/index_c.cpp 0.00% 3 Missing ⚠️
internal/core/src/index/VectorIndex.h 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #39272      +/-   ##
==========================================
+ Coverage   81.02%   81.05%   +0.02%     
==========================================
  Files        1400     1401       +1     
  Lines      197477   197195     -282     
==========================================
- Hits       160013   159829     -184     
+ Misses      31840    31758      -82     
+ Partials     5624     5608      -16     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.43% <75.00%> (-0.23%) ⬇️
Go 83.03% <ø> (+0.03%) ⬆️
Files with missing lines Coverage Δ
internal/core/src/index/Index.h 100.00% <ø> (ø)
internal/core/src/index/IndexFactory.cpp 86.30% <100.00%> (-3.85%) ⬇️
internal/core/src/index/IndexFactory.h 100.00% <ø> (ø)
internal/core/src/index/InvertedIndexTantivy.h 53.84% <ø> (+3.84%) ⬆️
internal/core/src/index/ScalarIndex.cpp 96.66% <100.00%> (ø)
internal/core/src/index/ScalarIndex.h 23.25% <ø> (ø)
...ernal/core/src/indexbuilder/ScalarIndexCreator.cpp 100.00% <100.00%> (ø)
internal/core/src/index/VectorIndex.h 58.97% <0.00%> (ø)
internal/core/src/indexbuilder/index_c.cpp 25.19% <0.00%> (-3.34%) ⬇️
internal/core/src/index/InvertedIndexTantivy.cpp 86.97% <67.92%> (-3.61%) ⬇️

... and 41 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Jan 15, 2025

@SpadeA-Tang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: SpadeA-Tang <[email protected]>
Copy link
Contributor

mergify bot commented Jan 15, 2025

@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 15, 2025

@SpadeA-Tang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007 czs007 added this to the 2.5.4 milestone Jan 15, 2025
Copy link
Contributor

mergify bot commented Jan 15, 2025

@SpadeA-Tang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 15, 2025

@SpadeA-Tang cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@SpadeA-Tang
Copy link
Contributor Author

rerun cpp-unit-test

@mergify mergify bot added the ci-passed label Jan 15, 2025
@czs007
Copy link
Collaborator

czs007 commented Jan 16, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, SpadeA-Tang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007
Copy link
Collaborator

czs007 commented Jan 16, 2025

rerun go-sdk

@sre-ci-robot sre-ci-robot merged commit 1d9788e into milvus-io:2.5 Jan 16, 2025
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants