Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Upgrade go version in docker images #39016

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

enhance: Upgrade go version in docker images #39016

wants to merge 3 commits into from
+20 −20

Conversation

XuanYang-cn
Copy link
Contributor

upgrade go version to 1.22.10

See also: #39011

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: XuanYang-cn
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jan 6, 2025
@XuanYang-cn XuanYang-cn mentioned this pull request Jan 6, 2025
Open
3 tasks
@mergify mergify bot added the dco-passed DCO check passed. label Jan 6, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 6, 2025

@XuanYang-cn

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly

Please review and update your PR to comply with these guidelines.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 6, 2025

@XuanYang-cn go-sdk check failed, comment rerun go-sdk can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Jan 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.82%. Comparing base (75d7978) to head (fc4b7ae).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39016      +/-   ##
==========================================
+ Coverage   81.03%   82.82%   +1.78%     
==========================================
  Files        1407     1107     -300     
  Lines      198527   171627   -26900     
==========================================
- Hits       160881   142154   -18727     
+ Misses      31987    23812    -8175     
- Partials     5659     5661       +2
Components Coverage Δ
Client 79.50% <ø> (ø)
Core ∅ <ø> (∅)
Go 82.96% <ø> (-0.02%) ⬇️

see 332 files with indirect coverage changes

@mergify mergify bot added ci-passed and removed ci-passed labels Jan 6, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 7, 2025

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@XuanYang-cn XuanYang-cn changed the title Upgrade go version in docker images enhance: Upgrade go version in docker images Jan 7, 2025
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/invalid-pr-format labels Jan 7, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 7, 2025

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label Jan 7, 2025
@congqixia congqixia mentioned this pull request Jan 9, 2025
Merged
sre-ci-robot pushed a commit that referenced this pull request Jan 9, 2025
@sunby
fix: Fix in filter search result is empty if pk type is varchar (#39108)
dad0d3b 
Cherry pick from master
pr: #39016
#39107

Signed-off-by: sunby <[email protected]>
@mergify mergify bot removed the ci-passed label Jan 13, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 13, 2025

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 13, 2025

@XuanYang-cn go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 13, 2025

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 13, 2025

@XuanYang-cn go-sdk check failed, comment rerun go-sdk can trigger the job again.

@XuanYang-cn
Upgrade go version in docker images
34a19f5 
upgrade go version to 1.22.10

See also: milvus-io#39011

Signed-off-by: yangxuan <[email protected]>
@XuanYang-cn XuanYang-cn force-pushed the upgrade-golang-version branch from 62c6c7a to 34a19f5 Compare January 14, 2025 07:00
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 14, 2025

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 15, 2025

@XuanYang-cn go-sdk check failed, comment rerun go-sdk can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

rerun ut

@XuanYang-cn
Copy link
Contributor Author

rerun go-sdk

@mergify mergify bot added the ci-passed label Jan 15, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 15, 2025

@XuanYang-cn go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify mergify bot removed the ci-passed label Jan 16, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 16, 2025

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@LoveEachDay LoveEachDay Awaiting requested review from LoveEachDay

Assignees
No one assigned
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XuanYang-cn @sre-ci-robot