Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add configs for compaction schedule #39010

Merged

Conversation

XuanYang-cn
Copy link
Contributor

No description provided.

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jan 6, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 6, 2025
Copy link
Contributor

mergify bot commented Jan 6, 2025

@XuanYang-cn go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.03%. Comparing base (75d7978) to head (2402d75).
Report is 43 commits behind head on master.

Files with missing lines Patch % Lines
pkg/util/paramtable/component_param.go 76.92% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39010      +/-   ##
==========================================
- Coverage   81.03%   81.03%   -0.01%     
==========================================
  Files        1407     1407              
  Lines      198527   198541      +14     
==========================================
- Hits       160885   160881       -4     
- Misses      31983    32001      +18     
  Partials     5659     5659              
Components Coverage Δ
Client 79.50% <ø> (ø)
Core 69.48% <ø> (-0.02%) ⬇️
Go 82.97% <81.25%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
internal/datacoord/compaction.go 71.32% <100.00%> (+0.05%) ⬆️
pkg/util/paramtable/component_param.go 98.33% <76.92%> (-0.07%) ⬇️

... and 34 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Jan 8, 2025

@XuanYang-cn go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 8, 2025

@XuanYang-cn cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify mergify bot added the ci-passed label Jan 8, 2025
configs/milvus.yaml Outdated Show resolved Hide resolved
@mergify mergify bot added ci-passed and removed ci-passed labels Jan 9, 2025
@XuanYang-cn
Copy link
Contributor Author

rerun ut

@mergify mergify bot added ci-passed and removed ci-passed labels Jan 9, 2025
@XuanYang-cn XuanYang-cn force-pushed the add-config-for-schedule-interval branch from 15c439f to 1d87ce0 Compare January 15, 2025 09:45
@mergify mergify bot removed the ci-passed label Jan 15, 2025
Copy link
Contributor

mergify bot commented Jan 15, 2025

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Jan 16, 2025
Copy link
Contributor

mergify bot commented Jan 16, 2025

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jan 17, 2025
@tedxu
Copy link
Contributor

tedxu commented Jan 22, 2025

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tedxu, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit bb8cc6e into milvus-io:master Jan 22, 2025
19 of 20 checks passed
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this pull request Jan 22, 2025
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this pull request Jan 22, 2025
@XuanYang-cn XuanYang-cn deleted the add-config-for-schedule-interval branch January 22, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants