Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:[2.4]Set the correct compactionFroms for clustering segments #38376

Merged

Conversation

xiaocai2333
Copy link
Contributor

issue: #38373
master pr: #36799
This bug was introduced by PR #37653 .

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 11, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Dec 11, 2024
Copy link
Contributor

mergify bot commented Dec 11, 2024

@xiaocai2333

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@xiaocai2333 xiaocai2333 changed the title Set the correct compactionFroms for clustering segments fix:[2.4]Set the correct compactionFroms for clustering segments Dec 11, 2024
@mergify mergify bot added kind/bug Issues or changes related a bug and removed do-not-merge/invalid-pr-format labels Dec 11, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 11, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.49%. Comparing base (ee40344) to head (7c8561f).
Report is 7 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38376      +/-   ##
==========================================
+ Coverage   79.47%   79.49%   +0.02%     
==========================================
  Files        1077     1077              
  Lines      168905   168922      +17     
==========================================
+ Hits       134242   134292      +50     
+ Misses      30209    30182      -27     
+ Partials     4454     4448       -6     
Files with missing lines Coverage Δ
internal/datacoord/meta.go 88.21% <100.00%> (ø)

... and 45 files with indirect coverage changes

@sre-ci-robot sre-ci-robot merged commit dde9d6c into milvus-io:2.4 Dec 11, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants