Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stream connection leak in case of error #38320

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix: stream connection leak in case of error #38320

merged 1 commit into from
Dec 11, 2024

Conversation

jaime0815
Copy link
Contributor

issue: #38318

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 10, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 10, 2024
@jaime0815 jaime0815 mentioned this pull request Dec 10, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.04%. Comparing base (224c2c8) to head (bde196f).
Report is 16 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38320       +/-   ##
===========================================
+ Coverage   68.83%   81.04%   +12.20%     
===========================================
  Files         289     1373     +1084     
  Lines       25507   191701   +166194     
===========================================
+ Hits        17559   155359   +137800     
- Misses       7948    30830    +22882     
- Partials        0     5512     +5512
Components Coverage Δ
Client 74.58% <ø> (∅)
Core 68.83% <ø> (ø)
Go 83.15% <100.00%> (∅)
Files with missing lines Coverage Δ
pkg/mq/msgdispatcher/dispatcher.go 94.08% <100.00%> (ø)

... and 1083 files with indirect coverage changes

@jaime0815 jaime0815 force-pushed the fix-stream-connection-leak branch from b8e68e4 to bde196f Compare December 10, 2024 13:10
@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Dec 10, 2024
@mergify mergify bot added the ci-passed label Dec 10, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 11, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 37a5228 into milvus-io:master Dec 11, 2024
20 checks passed
sre-ci-robot pushed a commit that referenced this pull request Dec 11, 2024
@jaime0815
fix: stream connection leak in case of error (#38321)
7cee01a 
issue: #38318
pr: #38320

Signed-off-by: jaime <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaofan-luan xiaofan-luan Awaiting requested review from xiaofan-luan

@zwd1208 zwd1208 Awaiting requested review from zwd1208

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaime0815 @czs007 @sre-ci-robot