Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Move SyncCreatedPartition step to proxy #38296

Merged

Conversation

congqixia
Copy link
Contributor

Related to #38275

This PR move sync created partition step to proxy to avoid potential logic deadlock when create partition happens with target segment change.

Related to milvus-io#38275

This PR move sync created partition step to proxy to avoid potential
logic deadlock when create partition happens with target segment change.

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 9, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 42.10526% with 11 lines in your changes missing coverage. Please review.

Project coverage is 81.05%. Comparing base (7a5aea1) to head (c052847).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
internal/proxy/task.go 38.88% 8 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38296      +/-   ##
==========================================
- Coverage   81.08%   81.05%   -0.04%     
==========================================
  Files        1372     1372              
  Lines      191671   191677       +6     
==========================================
- Hits       155412   155358      -54     
- Misses      30762    30815      +53     
- Partials     5497     5504       +7     
Components Coverage Δ
Client 74.58% <ø> (ø)
Core 68.83% <ø> (ø)
Go 83.16% <42.10%> (-0.04%) ⬇️
Files with missing lines Coverage Δ
internal/proxy/impl.go 84.92% <100.00%> (+<0.01%) ⬆️
internal/rootcoord/create_partition_task.go 90.80% <ø> (-0.60%) ⬇️
internal/rootcoord/step.go 86.80% <ø> (+1.27%) ⬆️
internal/proxy/task.go 86.66% <38.88%> (-0.38%) ⬇️

... and 33 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 9, 2024
Copy link
Member

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot merged commit fec31fe into milvus-io:master Dec 10, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants