Update the template expression proto to improve transmission efficiency #341
Conversation
proto/schema.proto
Outdated
| LongArray long_data = 2; | ||
| DoubleArray double_data = 3; | ||
| StringArray string_data = 4; | ||
| TemplateArrayValue array_data = 5; |
There was a problem hiding this comment.
why do we need TemplateArrayValue array_data = 5;?
if we have a proto TemplateArrayValue{array_data: TemplateArrayValue{bool_data: [true, false, false]}}, why not directly use TemplateArrayValue{bool_data: [true, false, false]}?
There was a problem hiding this comment.
array_data is used for multidimensional arrays, and the prototype for using it can be:
json["A"] == [[1,2,3], [4,5,6]].
It will be converted into: TemplateValue{array_val: TemplateArrayValue{array_data: [TemplateArrayValue{long_data: [1,2,3]}, TemplateArrayValue{long_data:[3,4,5]}]}}
There was a problem hiding this comment.
but TemplateArrayValue array_data is not repeated, how can you put 2 TemplateArrayValue{long_data in a single TemplateArrayValue{array_data?
your example formatted:
TemplateValue{array_val:
TemplateArrayValue{array_data: [
TemplateArrayValue{long_data: [1,2,3]},
TemplateArrayValue{long_data:[3,4,5]}
]}
}
There was a problem hiding this comment.
o~, need repeated.
There was a problem hiding this comment.
update it, please review again.
Signed-off-by: Cai Zhang <[email protected]>
xiaocai2333
force-pushed
the
update_expression_proto
branch
from
3e358a2 to
4d6ad9c
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xiaocai2333, yhmo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue: milvus-io/milvus#36672