Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proto for sparse float vector #232

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Add proto for sparse float vector #232

merged 3 commits into from
Jan 31, 2024

Conversation

zhengbuqian
Copy link
Contributor

/kind feature
issue : milvus-io/milvus#29419

@sre-ci-robot
Copy link

@zhengbuqian: The label(s) kind/feature cannot be applied, because the repository doesn't have them.

In response to this:

/kind feature
issue : milvus-io/milvus#29419

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zhengbuqian
Copy link
Contributor Author

/hold

@sre-ci-robot
Copy link

Welcome @zhengbuqian! It looks like this is your first PR to milvus-io/milvus-proto 🎉

@mergify mergify bot added the dco-passed DCO check passed. label Dec 22, 2023
@zhengbuqian
Copy link
Contributor Author

/unhold

@zhengbuqian
Copy link
Contributor Author

@yhmo @xige-16 PTAL, thanks!

@zhengbuqian zhengbuqian mentioned this pull request Jan 29, 2024
Merged
@xige-16
Copy link
Contributor

xige-16 commented Jan 31, 2024

/lgtm

@yhmo
Copy link
Collaborator

yhmo commented Jan 31, 2024

/approve

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yhmo, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Jan 31, 2024
@sre-ci-robot sre-ci-robot merged commit 9e75d61 into milvus-io:master Jan 31, 2024
4 checks passed
@zhengbuqian zhengbuqian deleted the sparse-v4 branch February 2, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuanYang-cn XuanYang-cn Awaiting requested review from XuanYang-cn

@yhmo yhmo Awaiting requested review from yhmo

Assignees

@xige-16 xige-16

Labels
approved ci-passed dco-passed DCO check passed. lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhengbuqian @sre-ci-robot @xige-16 @yhmo