Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbt-github-actions to 0.14.2 #1216

Merged

Conversation

scala-steward
Copy link
Contributor

Updates com.codecommit:sbt-github-actions from 0.13.0 to 0.14.2.

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Files still referring to the old version number

The following files still refer to the old version number (0.13.0).
You might want to review and update them manually.

notes/2.0.0-M1.markdown
Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.codecommit", artifactId = "sbt-github-actions" } ]

labels: sbt-plugin-update, early-semver-major, semver-spec-minor, old-version-remains

@joroKr21 joroKr21 requested a review from milessabin February 11, 2022 09:25
@joroKr21 joroKr21 force-pushed the update/sbt-github-actions-0.14.2 branch from 5de8870 to d9866ed Compare March 17, 2023 08:04
@joroKr21 joroKr21 force-pushed the update/sbt-github-actions-0.14.2 branch from 0c5b77c to d9866ed Compare March 17, 2023 11:10
@joroKr21 joroKr21 force-pushed the update/sbt-github-actions-0.14.2 branch from d9866ed to 99faa8f Compare April 25, 2024 19:55
@joroKr21 joroKr21 force-pushed the update/sbt-github-actions-0.14.2 branch from 34024e3 to 89a18d3 Compare September 22, 2024 09:13
Copy link
Owner

@milessabin milessabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joroKr21 joroKr21 force-pushed the update/sbt-github-actions-0.14.2 branch from 5d77886 to 15ea4b4 Compare February 26, 2025 20:22
@joroKr21
Copy link
Collaborator

Is it possible to not rely on the GitHub check names? Every time they change, we can't merge the PR

@milessabin
Copy link
Owner

Is it possible to not rely on the GitHub check names?

I don't understand that question? Do you mean the ability to bypass the checks? We should have that (I do, and I don't see anything in settings which looks like it would prevent you from bypassing as well).

@joroKr21
Copy link
Collaborator

This is what I see, the required checks are no longer there (the name changed)

Screenshot 2025-02-26 at 21 40 33

@milessabin
Copy link
Owner

@joroKr21 gotcha ... I was expecting you to have the ability to bypass the protection rules.

I've disabled them for now because I can't see an obvious way to grant you that permission.

I attempted to set up a "ruleset" which would allow me to grant that permission to holders of a "Maintain" role, but having done that I couldn't see any way to assign that role to you. Possibly the only way to do this is to set up a team ... I'll look in to that later.

@joroKr21
Copy link
Collaborator

Cool, thanks 👍

@joroKr21 joroKr21 merged commit f94fdcb into milessabin:main Feb 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants