Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the shape assertion error in the evaluation stage of one-class se… #446

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

littsk
Copy link

@littsk littsk commented Jun 5, 2023

Hello,

I have detected an assertion error bug in evaluation stage of one class segmentation situation.

To fix this, I made a change as follow:

diff --git a/evaluate.py b/evaluate.py
index 9a4e3ba..42eb064 100644
--- a/evaluate.py
+++ b/evaluate.py
@@ -27,7 +27,7 @@ def evaluate(net, dataloader, device, amp):
                 assert mask_true.min() >= 0 and mask_true.max() <= 1, 'True mask indices should be in [0, 1]'
                 mask_pred = (F.sigmoid(mask_pred) > 0.5).float()
                 # compute the Dice score
-                dice_score += dice_coeff(mask_pred, mask_true, reduce_batch_first=False)
+                dice_score += dice_coeff(mask_pred.squeeze(1), mask_true, reduce_batch_first=False)

Although it is very easy, I believe that my bug fix resolves the issue effectively and improves the overall stability and functionality of the project.

Please review the changes and let me know if any further modifications or adjustments are required. I am open to feedback and suggestions to make the solution even better.

Thank you for your time and consideration.

Best regards

@PairZhu
Copy link

PairZhu commented Aug 17, 2024

I found that problem, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants