Pframes ranking feature middle-layer

[AStaroverov]

No description provided.

[changeset-bot]

🦋 Changeset detected

Latest commit: 93a173f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages

Name	Type
@milaboratories/pl-model-common	Patch
@platforma-sdk/ui-vue	Patch
@platforma-sdk/model	Patch
@milaboratories/pl-model-middle-layer	Patch
@milaboratories/pl-client	Patch
@milaboratories/pl-drivers	Patch
@milaboratories/pl-middle-layer	Patch
@milaboratories/pl-deployments	Patch
@platforma-open/milaboratories.software-ptabler.schema	Patch
@platforma-sdk/block-tools	Patch
@milaboratories/milaboratories.monetization-test.ui	Patch
@milaboratories/milaboratories.ui-examples.ui	Patch
@milaboratories/milaboratories.pool-explorer.ui	Patch
@milaboratories/pf-driver	Patch
@milaboratories/uikit	Patch
@milaboratories/milaboratories.monetization-test.model	Patch
@milaboratories/milaboratories.ui-examples.model	Patch
@milaboratories/milaboratories.ui-examples	Patch
@milaboratories/milaboratories.pool-explorer.model	Patch
@milaboratories/milaboratories.pool-explorer	Patch
@milaboratories/pl-model-backend	Patch
@milaboratories/pl-errors	Patch
@milaboratories/pl-tree	Patch
@platforma-sdk/test	Patch
@platforma-sdk/bootstrap	Patch
@milaboratories/ptabler-expression-js	Patch
@milaboratories/milaboratories.monetization-test	Patch
@platforma-sdk/tengo-builder	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily introduces the foundational support for a new pframes ranking feature by adding a dedicated feature flag. It includes necessary dependency updates for pframes-related packages and refactors the AG-Grid integration within the UI SDK for better modularity. Additionally, the SDK's application definition now exposes feature flags, enabling more dynamic and feature-aware application behavior.

Highlights

• Pframes Ranking Feature Flag: Introduced a new feature flag supportsPframeQueryRanking to enable a pframes ranking capability within the system, updating relevant feature flag definitions and initializations.
• Dependency Updates: Updated core pframes-rs and related @milaboratories package dependencies to version 1.1.12 across the project, ensuring compatibility and leveraging the latest features.
• AG-Grid Refactoring: Refactored AG-Grid initialization and theming logic by moving activateAgGrid and AgGridTheme to more appropriate, modular locations within the sdk/ui-vue module for improved organization and maintainability.
• Feature Flag Exposure in SDK: Enhanced the SDK's defineApp and SdkPlugin to expose featureFlags, allowing applications to dynamically adapt their behavior based on enabled features.

Changelog

• lib/model/common/src/flags/block_flags.ts
  • Added supportsPframeQueryRanking to BlockCodeKnownFeatureFlags
  • Updated AllSupportsFeatureFlags to include supportsPframeQueryRanking
• pnpm-lock.yaml
  • Updated @milaboratories/pframes-rs-node to version 1.1.12
  • Updated @milaboratories/pframes-rs-wasm to version 1.1.12
  • Updated @milaboratories/pl-error-like to version 1.12.9
  • Updated @milaboratories/pl-model-common to version 1.25.2
• pnpm-workspace.yaml
  • Updated @milaboratories/pframes-rs-node and @milaboratories/pframes-rs-wasm versions in the catalog to 1.1.12
• sdk/model/src/block_model.ts
  • Included supportsPframeQueryRanking in INITIAL_BLOCK_FEATURE_FLAGS
  • Adjusted blockConfig assignment logic to pass featureFlags to getPlatformaInstance
• sdk/model/src/block_model_legacy.ts
  • Included supportsPframeQueryRanking in INITIAL_BLOCK_FEATURE_FLAGS
  • Refactored conditional return logic for getPlatformaInstance to pass featureFlags
• sdk/model/src/platforma.ts
  • Imported BlockCodeKnownFeatureFlags type
  • Added featureFlags property to BlockModelInfo type
• sdk/ui-vue/src/AgGridVue/createAgGridColDef.ts
  • Removed a redundant eslint-disable comment
• sdk/ui-vue/src/AgGridVue/useAgGridOptions.ts
  • Removed a redundant eslint-disable comment
  • Updated the import path for AgGridTheme
• sdk/ui-vue/src/aggrid.ts
  • Renamed to sdk/ui-vue/src/components/PlAgDataTable/compositions/useTheme.ts
  • Refactored the AgGridTheme export
  • Removed activateAgGrid and AG-Grid license management logic
• sdk/ui-vue/src/components/PlAgDataTable/PlAgDataTableV2.vue
  • Updated the import path for AgGridTheme
• sdk/ui-vue/src/components/PlAgDataTable/index.ts
  • Imported and invoked activateAgGrid from the new lib path
• sdk/ui-vue/src/components/PlTableFilters/PlTableFiltersV2.vue
  • Imported useSdkPlugin
  • Initialized an sdk constant using useSdkPlugin
• sdk/ui-vue/src/composition/AgGrid/index.ts
  • Added a new file containing the activateAgGrid function
  • Implemented AG-Grid module registration and license management within activateAgGrid
• sdk/ui-vue/src/defineApp.ts
  • Imported BlockCodeKnownFeatureFlags
  • Removed direct calls to activateAgGrid
  • Introduced a new useFeatureFlags hook
  • Added featureFlags to SdkPlugin types (V1, V2, V3)
  • Exposed featureFlags in the reactive plugin object
• sdk/ui-vue/src/internal/createAppV1.ts
  • Removed an unnecessary unknown as type assertion
• sdk/ui-vue/src/internal/createAppV2.test.ts
  • Updated test blockModelInfo objects to include an empty featureFlags property
• sdk/ui-vue/src/internal/createAppV3.test.ts
  • Updated test blockModelInfo objects to include an empty featureFlags property
• sdk/ui-vue/src/lib.ts
  • Updated the export path for AG-Grid related utilities from aggrid to composition/AgGrid

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new feature flag supportsPframeQueryRanking and ensures it's propagated from the model to the UI layer. It also includes a significant and well-structured refactoring of the AG Grid related code, improving modularity. The changes are generally good, but I've identified a couple of issues: an unused variable and a potential typing error that could lead to runtime issues. Please see my detailed comments.

[gemini-code-assist]

This comment /**/ seems to be a leftover from removing an eslint-disable comment. It can be removed completely for better code clarity.