Skip to content

Replace FROM scratch with ubuntu:24.04 in Dockerfiles#1477

Open
vgpopov wants to merge 2 commits intomainfrom
chore/replace-scratch-with-ubuntu
Open

Replace FROM scratch with ubuntu:24.04 in Dockerfiles#1477
vgpopov wants to merge 2 commits intomainfrom
chore/replace-scratch-with-ubuntu

Conversation

@vgpopov
Copy link
Contributor

@vgpopov vgpopov commented Mar 2, 2026

Purpose

Scratch base images lack basic tooling and debugging capabilities, making container troubleshooting difficult. Replace with pinned Ubuntu 24.04 LTS for a consistent, debuggable base.

Changes

  • Replace FROM scratch with FROM ubuntu:24.04 in lib/other/biowasm-tools/Dockerfile (multi-stage final stage)
  • Replace FROM scratch with FROM ubuntu:24.04 in tests/package-builder/30.software-pkg/Dockerfile
  • Replace FROM scratch with FROM ubuntu:24.04 in tools/package-builder/src/__test__/Dockerfile

Tests

No new tests — config-only Dockerfile change, covered by existing Docker build CI.

Scratch base images lack basic tooling and debugging capabilities.
Use pinned ubuntu:24.04 LTS instead.
@changeset-bot
Copy link

changeset-bot bot commented Mar 2, 2026

🦋 Changeset detected

Latest commit: c5f69e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@milaboratories/biowasm-tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the base image in several Dockerfiles from scratch to ubuntu:24.04. This change enhances debugging capabilities and ensures a consistent build environment by leveraging a standard Ubuntu image with readily available tools.

Highlights

  • Base Image Update: Replaced FROM scratch with FROM ubuntu:24.04 in multiple Dockerfiles to provide a consistent and debuggable base image.
  • Improved Debugging: Using Ubuntu 24.04 LTS as the base image allows for easier troubleshooting due to the availability of standard tooling.
  • Consistent Environment: Pinning the base image to Ubuntu 24.04 ensures a consistent environment across different builds.
Changelog
  • lib/other/biowasm-tools/Dockerfile
    • Replaced FROM scratch with FROM ubuntu:24.04 in the final stage of the multi-stage Dockerfile.
  • tests/package-builder/30.software-pkg/Dockerfile
    • Replaced FROM scratch with FROM ubuntu:24.04.
  • tools/package-builder/src/test/Dockerfile
    • Replaced FROM scratch with FROM ubuntu:24.04.
Activity
  • vgpopov replaced the base image in three Dockerfiles.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.61%. Comparing base (6689b53) to head (c5f69e2).
⚠️ Report is 86 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1477      +/-   ##
==========================================
+ Coverage   52.77%   54.61%   +1.84%     
==========================================
  Files         239      242       +3     
  Lines       13472    13554      +82     
  Branches     2787     2773      -14     
==========================================
+ Hits         7110     7403     +293     
+ Misses       5459     5226     -233     
- Partials      903      925      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants