compatibility with old subprocess.run API #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subprocess.run has added support for capture_output only in python 3.7. Even if python <=3.6 is officially out of support, users can still encounter it on Slurm frontends, where stui is likely to be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for your nice job :)
It just wanted to add this fix this so stui can run on my cluster.
Let me know if you want anything changed.
Commit message:
subprocess.run has added support for capture_output only in
python 3.7. Even if python <=3.6 is officially out of support,
users can still encounter it on Slurm frontends, where stui
is likely to be used.