Tune up course project readme

mikzat · Jun 17, 2016 · 1c9e583 · 1c9e583
1 parent d935505
commit 1c9e583
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/final-project/ANSWERS.md b/final-project/ANSWERS.md
@@ -0,0 +1,20 @@
+
+- Missing responsive viewport tag
+  - Students will need to add meta viewport with width=device-width and initial-scale=1
+- No lang set on <html>
+  - Student will need to add `lang=en`. This should get picked up by the a11y audit extension if they use it
+- `<a>` has outline: none;
+  - Students can either remove this, or replace it with their own outline styles
+- Body text is low contrast
+  - Students need to change body color to at least #757575; The a11y audit tool will point this out
+- Subscribe form elements are labeled with divs
+  - Student should replace these with `<label>`
+- Subscribe form submit button is a div
+  - Student should replace this with `<input type="submit">`
+- Hot List and Subscribe headings have tabindex=0
+  - Students should remove these tabindex attributes
+- Optional: Main content is missing a heading
+  - Students can add a heading. If they don’t like the appearance they can make it offscreen so it’s only visible to screen readers
+- Missing landmarks
+  - Students should replace divs with nav, main, and aside elements
+- Optional: Students can add a skip link to jump to main content
diff --git a/final-project/README.md b/final-project/README.md
@@ -4,4 +4,9 @@ It's time to take the skills you've learned in this course and apply them to
 a real project. We've gone ahead and created a very fancy looking site but
 there are a number of accessibility issues that could be improved. Do your
 best to fix as many as you can and if you get stuck or need a hint you can
-check out the [answers file](ANSWERS.md).
+check out the [answers file](ANSWERS.md) or the [full solution](https://github.com/udacity/ud891/tree/gh-pages/final-project/ecommerce-site/solution).
+
+Accessibility is one of those things that you can always improve upon so it's
+very possible you'll think up additions and solutions that even we didn't
+cover in our final version. Have fun with it and see if you can build an
+access that you think all of your users will love.