Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for discarded and hidden tabs #5

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

esanchma
Copy link
Contributor

This PR enables context menu checkboxes for discarded and hidden tabs. To do so, it needs a couple of new permissions.

It also merges the 2 previous PRs.

@mikl This extension hasn't have any activity in 6 years. How do you feel about doing an update in AMO? If you don't want to do it, maybe I could change the id and upload it myself?

TheIronBorn and others added 4 commits September 3, 2018 18:14
Added a pair of context menu checkboxes so the tab filter can
include discarded and hidden tabs.

To save the checkbox state, we are using the storage api, so we
need storage permissions.
@esanchma esanchma changed the title Hiddendiscarded Adding support for discarded and hidden tabs Dec 13, 2022
@mikl
Copy link
Owner

mikl commented Jan 8, 2023

Hi there,

I’ve merged #1 and #2, and I’m working to make the extension work in Chrome-based browsers as well as Safari.

This change is a little more involved, and I’d like to wait until I have cross-browser compatibility working before adding additional complexity, hope you understand.

@mikl
Copy link
Owner

mikl commented Jan 8, 2023

Looking at the Chrome Documentation, they have no filter option for hidden tabs: https://developer.chrome.com/docs/extensions/reference/tabs/#method-query – and giving unknown options causes errors, so we can’t easily add this filter if we want to keep cross-browser compatibility.

@esanchma
Copy link
Contributor Author

esanchma commented Jan 9, 2023

Looking at the Chrome Documentation, they have no filter option for hidden tabs: https://developer.chrome.com/docs/extensions/reference/tabs/#method-query – and giving unknown options causes errors, so we can’t easily add this filter if we want to keep cross-browser compatibility.

Yes, hidden tabs seem to be a firefox only thing. Maybe a check on typeof tabs.hide == "function" to do that only in firefox may make sense there. I'll try to rebase this PR over that

@mikl mikl marked this pull request as draft January 9, 2023 23:08
@mikl
Copy link
Owner

mikl commented Jan 9, 2023

Alright, I’ll mark this MR as a draft for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants