Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

can get route from archetypefieldsetmodel #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

can get route from archetypefieldsetmodel #1

wants to merge 2 commits into from

Conversation

wiedikerli
Copy link

No description provided.

@mikkelhm
Copy link
Owner

Hi tobaiasjs,

Thank you so much for contributing, its very valuable.

Eventhough i like that you have added the support for Archetype, i would really like for it not to be there. The reason is that it makes the code dependable on a 3rd party assembly, that isnt part of the Umbraco core. I even see that Archetype gives trouble in Umbraco 7.2.2.

Ill investegate how this can be worked arround somehow, and mabye merge the pull request later.

Also: i think something went wrong while committing the pull request. this commit https://github.com/tobaiasjl/Umbraco-Google-maps-routeplanner-property-editor/commit/96756f83e872f74133da78005425f8672d62a2d3
contains 79 file changes! Considering that the whole project contains about 10 files, something seems wrong.

@wiedikerli
Copy link
Author

those 79 files coming from the umbraco bins. i added them to the folder "externals". cause when i cloned it, i couldnt build cause of missing references.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants