Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DashboardView Empty View #287

Merged

Conversation

ItsJakeMarcus
Copy link
Contributor

This code adds a ContentUnavailableView to the DashboardView. Its purpose is to create a user friendly UI for when there are no maintenance jobs in the list.

How I Tested

  • Add a list of steps to show the functionality of your feature
    For example:
  • Run the application
  • On launch, the DashboardView will show a loading screen, and then the ContentUnavailableView
  • You can add a maintenance task, which will replace the ContentUnavailableView, and delete them all, which will bring it back.

Notes

  • N/A

Screenshot

image

Copy link
Owner

@mikaelacaron mikaelacaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Just a few comments of some things that need to be changed before it's merged

If you have any questions, you can comment directly on that thread, otherwise click the resolve button once you've addressed my comment. Once you fix everything, please click the re-review button

Re-review button

@mikaelacaron mikaelacaron changed the title Task 286 - Improve DashboardView completed. Improve DashboardView Empty View Jul 25, 2024
Removed VStack
Removed isShowingAddVehicleView
Copy link
Owner

@mikaelacaron mikaelacaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on your first PR!! Thanks for contributing!

I fixed the tabbing because there was extra space above and below the ContentUnavailableView that didn't need to be there

@mikaelacaron mikaelacaron merged commit 3a15c4b into mikaelacaron:dev Jul 26, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IMPROVE - Empty DashboardView
2 participants