Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lit-html as an example of an importable module #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

prantlf
Copy link
Contributor

@prantlf prantlf commented Jan 2, 2022

No description provided.

@wkeese
Copy link

wkeese commented Jan 4, 2022

I already wrote this in #35, but for reference, my test with lit-html V1.1.2 was to test issues with relative paths and .js extensions, specifically how lit-html.js did import statements like

import { defaultTemplateProcessor } from './lib/default-template-processor.js';

This PR is loading lit-html V2.0.2, which doesn't seem to import anything, although it's hard to tell because it's minimized.

If your goal is to make a test case then probably loading lit-html V1 is better.

In any case, please test your #39 against lit-html 1.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants