Fix #197 - Scroll crashing #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaiserbh
pushed a commit
to kaiserbh/mihon
that referenced
this pull request
Feb 18, 2024
Updating compose bom. (cherry picked from commit 5dc6501)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #197
We are using Chris Bane's compose BOM to manage the compose versions. This BOM differs from the official for using the latest non-stable versions of the libraries. This crash was caused by a bug in the compose-ui.
I could not update to the latest version because we are using several deprecated APIs that are not present in the latest version, so to update to it would not be worth the effort. Ideally, we would use the official stable version to avoid this type of crash.
How to test
Please checkout and try to reproduce the issue before merging it. I could only test it in two physical devices.
1- Go to the browser
2- Extensions tab
3- Scroll down as fast as possible
4- change tab while scrolling
5- it should not crash
Video
scroll_crash_fix.mp4