Adding Type-safe project accessors #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntsyLich
reviewed
Jan 22, 2024
AntsyLich
reviewed
Jan 23, 2024
kaiserbh
pushed a commit
to kaiserbh/mihon
that referenced
this pull request
Feb 18, 2024
* replace the windowInsetsPadding for navigationBarsPadding + statusBarsPadding * Enabling TYPESAFE_PROJECT_ACCESSORS * Adding typesafe project accessors in the app module * Adding typesafe project accessors in the core module * Adding typesafe project accessors in the core-metadata module * Adding typesafe project accessors in the data module * Adding typesafe project accessors in the domain module * Adding typesafe project accessors in the presentation-core module * Adding typesafe project accessors in the presentation-widget module * Adding typesafe project accessors in the source-local module * Adding typesafe project accessors in the source-api module * Rolling back * Changing TYPESAFE_PROJECT_ACCESSORS line * Removing extra spaces (cherry picked from commit e17d87f)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the app has several modules, we can take advantage of the gradle new feature. The project accessors are mapped from the project path. For example, if a project path is
:commons:utils:some:libthen the project accessor will beprojects.commons.utils.some.lib.before:
dependencies { implementation(project(":i18n")) implementation(project(":core")) }after:
dependencies { implementation(projects.i18n) implementation(projects.core) }This way we don't need to relay on strings that are prone to error.