-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for Export and Import of Custom Covers #1797
base: main
Are you sure you want to change the base?
Conversation
How does this work? |
What do you mean how does this work? EDIT: Uses the manga url as a unique key to backup and restore covers stores into a gz (cus the manga id can change) |
e20c51a
to
054b9e1
Compare
054b9e1
to
49e1515
Compare
Can someone rerun build cus I don't want any more force pushes showing xD |
A potential issue I see here is in case a manga url or source id (which should be part of backup. manga is unique by source and url) changes any old backup will have some redundancy |
What are the chances tho that 2 manga have the same URL EDIT: I guess most sources now don't out the full URL in the URL field so it is possible |
Would you like me to add the sourceID to the protobuf too and use that while restoring? |
Yes |
I didn't bother retesting like I usually do with changes, but it a pretty minor change so fingers crossed |
That's how I ended up having to make three follow-up PRs to #1748... |
Resolves #16
