Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for Export and Import of Custom Covers #1797

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Animeboynz
Copy link
Contributor

@Animeboynz Animeboynz commented Mar 1, 2025

Resolves #16
image

@MajorTanya
Copy link
Member

How does this work?

@Animeboynz
Copy link
Contributor Author

Animeboynz commented Mar 1, 2025

What do you mean how does this work?

EDIT: Uses the manga url as a unique key to backup and restore covers stores into a gz (cus the manga id can change)
it also stores a protobuf inside the archive to link filenames to the urls

@Animeboynz
Copy link
Contributor Author

Animeboynz commented Mar 1, 2025

Can someone rerun build cus I don't want any more force pushes showing xD

@AntsyLich
Copy link
Member

A potential issue I see here is in case a manga url or source id (which should be part of backup. manga is unique by source and url) changes any old backup will have some redundancy

@Animeboynz
Copy link
Contributor Author

Animeboynz commented Mar 2, 2025

What are the chances tho that 2 manga have the same URL

EDIT: I guess most sources now don't out the full URL in the URL field so it is possible

@Animeboynz
Copy link
Contributor Author

Would you like me to add the sourceID to the protobuf too and use that while restoring?

@AntsyLich
Copy link
Member

Yes

@Animeboynz
Copy link
Contributor Author

I didn't bother retesting like I usually do with changes, but it a pretty minor change so fingers crossed

@MajorTanya
Copy link
Member

I didn't bother retesting like I usually do with changes, but it a pretty minor change so fingers crossed

That's how I ended up having to make three follow-up PRs to #1748...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backup support for custom cover
3 participants