Include Coil's broken hardware bitmap device list #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Declares all listed devices as unable to use hardware bitmaps. Might fix mihonapp#1541.
This hides the setting from the UI if the user's device in on Coil's list of devices with problematic hardware bitmap implementations. Also moved HARDWARE_BITMAP_UNSUPPORTED into the ImageUtil as a property for more ergonomic access across the project.
Also fix typo in CHANGELOG.md
cuong-tran
pushed a commit
to komikku-app/komikku
that referenced
this pull request
Dec 6, 2024
* Include Coil's broken hardware bitmap device list Declares all listed devices as unable to use hardware bitmaps. Might fix mihonapp/mihon#1541. * Hide Hardware Bitmap Threshold setting if unusable This hides the setting from the UI if the user's device in on Coil's list of devices with problematic hardware bitmap implementations. Also moved HARDWARE_BITMAP_UNSUPPORTED into the ImageUtil as a property for more ergonomic access across the project. * Add missing negation * Update CHANGELOG.md * Update CHANGELOG.md * Needs to be and not or Also fix typo in CHANGELOG.md --------- Co-authored-by: AntsyLich <[email protected]> (cherry picked from commit 7f2cfb5eb224896d6d0ffa6960f0a98c7325e240)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declares all listed devices as unable to use hardware bitmaps and hides the Hardware Bitmap Threshold setting on all such devices.
Might fix #1541.