Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app update error notification always disappeared #1476

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

cuong-tran
Copy link
Contributor

How to reproduce the issue

  1. Try downloading the app update on a slow network - Or purposely decrease network.client.callTimeout to just 1-3 seconds.
  2. Wait for the timeout exception to occur (could be any other exception that could be manipulated to occur)

Expect

  • The Download Error notification should be shown after the Downloading notification hides.

Actual

  • The Downloading notification hides and there are no more notification.

Reason

  • AppUpdateDownloadJob foreground is set tied to Notifications.ID_APP_UPDATER
  • The Download Error notification also use Notifications.ID_APP_UPDATER - debug shows that it is actually called to show
  • But when Job is done (i.e. download stoped for any reason), the whole Notifications.ID_APP_UPDATER is closed and hence clearing the Download Error notification.

@AntsyLich AntsyLich merged commit 88aff2c into mihonapp:main Nov 20, 2024
1 check passed
@cuong-tran cuong-tran deleted the app-update-error-notification branch November 20, 2024 18:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants