-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always update fresh data from source if manga isn't favorited #1435
base: main
Are you sure you want to change the base?
Conversation
domain/src/main/java/tachiyomi/domain/manga/interactor/NetworkToLocalManga.kt
Show resolved
Hide resolved
NetworkToLocalManga
domain/src/main/java/tachiyomi/domain/manga/interactor/NetworkToLocalManga.kt
Outdated
Show resolved
Hide resolved
remove changelog update |
domain/src/main/java/tachiyomi/domain/manga/interactor/NetworkToLocalManga.kt
Outdated
Show resolved
Hide resolved
eaa0944
to
b8997ec
Compare
domain/src/main/java/tachiyomi/domain/manga/interactor/NetworkToLocalManga.kt
Outdated
Show resolved
Hide resolved
What happens if you have a 'initialized' non library entry loaded with full data but while browsing source returns a not 'initialized' data 🤔 |
'initialized' is being used to make app check for manga's detail. If a 'initialized' non-library entry loaded with full data while source returns a not 'initialized' will make app auto refresh tags/descriptions/author... again when user decides to open the entry. Pretty mush like pull-refresh every time he open that entry (except for not checking chapters). I think this will be useful too, since a non-library entry can also updates its details information. |
If the browse manga is initialized update everything otherwise only update the title and thumbnail |
…pdate the title and thumbnail
although I made the change as per your request but I don't really get it though. When browsing, an non-initialized manga would also only has title & cover available, the rest are null. And null value won't overwrite already existed data of database's entries. |
This seems cause performance issue while browsing caused by database overwrite. Need to find another way. Maybe, only use new info for display without updating database while browsing. And only update database on manga opening or manual refresh manga. How about that? |
i guess keep this draft until the db rework (#1195) |
while browsing source, new data (title, cover...) will be updated to db if it isn't favorited yet
Closes #923