Adding bottom padding to Page Indicator to avoid phone's frame hide it #1140
Conversation
| @@ -35,6 +38,7 @@ fun PageIndicatorText( | |||
| ) | |||
|
|
|||
| Box( | |||
| modifier = Modifier.padding(bottom = 12.dp), | |||
There was a problem hiding this comment.
This is not the way. You need to apply insets as padding instead of some arbitrary value. THo I've tried doing it but was unsuccessful.
There was a problem hiding this comment.
I'm also having issues with WindowInsets. I guess it's because we're hiding the bottom buttons of the phone, and this causes it not to behave as usual.
But I'll try a few more ways to work around this without using a fixed value for the padding.
There was a problem hiding this comment.
I couldn't come to a conclusion about which WindowInsets to use. We have safeGestures and safeContent that work, but I'm not sure if they are the most appropriate for this case.
We also have navigationBarsIgnoringVisibility, which seems the most correct in this situation in my view, and it works very well when the phone is using the Navigation Bar with Swipe Gestures. However, when using the Navigation Bar with buttons, the padding becomes really large.
Can you help me decide which direction to take?
This fixes #1105
The Page Indicator at the bottom of the page was being cut in half because of Samsung's Phone Frame, and it is not possible to read the page number.
The padding I'm using is based on other places in the app that use the same padding at the bottom to avoid this.
note: This is my first PR to Mihon repository
Images