Add language and search related methods in Source #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+46
to
+54
| /** | ||
| * Get a page with a list of manga. | ||
| * | ||
| * @since extensions-lib 1.5 | ||
| * @param query the search query. | ||
| * @param filters the list of filters to apply. | ||
| * @param page the page number to retrieve. | ||
| */ | ||
| suspend fun getMangaList(query: String, filters: FilterList, page: Int): MangasPage = throw Exception("Stub!") |
There was a problem hiding this comment.
why a new search method in Source? what about getSearchManga
There was a problem hiding this comment.
the PR is towards the main branch which doesn't have getSearchManga but either way this is basically replacing it.
| @@ -21,6 +23,36 @@ interface Source { | |||
| */ | |||
| val name: String | |||
|
|
|||
| /** | |||
| * Represents an IETF BCP 47 compliant language tag. | |||
There was a problem hiding this comment.
do we need to specify regions and scripts in languages?
There was a problem hiding this comment.
This is just correctly representing what app expected for extensions to return and extensions were returning for lang property
There was a problem hiding this comment.
like pt-br, zh-Hant, zh-TW etc. are IETF BCP 47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.