Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plane splitPolygon running into loop / StackOverflowError #53

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Plane splitPolygon running into loop / StackOverflowError #53

wants to merge 7 commits into from

Commits on Mar 11, 2019

  1. creative fix for stackoverflow issue 

    we're adjusting two things... still the root cause of the stackoverflow is still not clear.
we're using a random polygon to define the plane for the node. chances are bigger that find a a coplanar polygon.
then if we have only one polygon as an input, we're expecting it to be coplanar.

a better alternative  may be to say that as long as the polygon from which we defined the plane is not SPANNING, it must be COPLANAR. 

anyway, this fix made my situation work again. 

maybe the issues arise from bigger models somewhere in the 100 dimension
    @udatny
    udatny authored Mar 11, 2019
    Configuration menu
    Copy the full SHA
    a1b3217 View commit details
    Browse the repository at this point in the history

  2. added pom.xml 

    for maven-based builds
    @udatny
    udatny authored Mar 11, 2019
    Configuration menu
    Copy the full SHA
    0322cd4 View commit details
    Browse the repository at this point in the history

  3. another fix for the stack overflow issue 

    this is a quick and dirty fix which does the job.
    @udatny
    udatny authored Mar 11, 2019
    Configuration menu
    Copy the full SHA
    3e4b3f6 View commit details
    Browse the repository at this point in the history

  4. revert 

    revert
    @udatny
    udatny authored Mar 11, 2019
    Configuration menu
    Copy the full SHA
    d36b100 View commit details
    Browse the repository at this point in the history

  5. reproduction of stackoverflow 

    run this test to reproduce the StackOverflowError
    @udatny
    udatny authored Mar 11, 2019
    Configuration menu
    Copy the full SHA
    23a2617 View commit details
    Browse the repository at this point in the history

  6. adding test for reproduction and a fix

    @udatny
    udatny committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    48fa221 View commit details
    Browse the repository at this point in the history

  7. revert 

    revert
    @udatny
    udatny authored Mar 11, 2019
    Configuration menu
    Copy the full SHA
    8da48f9 View commit details
    Browse the repository at this point in the history