Finalize PHP 8 support #72
Open
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PHP 8 an empty path will trigger "Path cannot be empty" ValueError, which will not be suppressed by `@`. Thus, we need to check for an empty path separately.
|
@mihaeu could you provide your feedback? |
|
@mihaeu Any movement on this? |
|
@mihaeu Is this package still being maintained? We also need PHP 8 support and it seems as there is no movement on this since about a year. |
|
Hi @janpawellek and rest, sorry for slacking off :( I transitioned in my job and didn't give this project as much attention as it deserves. I'll try to get this PR merged within the next couple of days. Thanks for the motivation 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see that 075d60d adds PHP 8 support, but some things are still missing:
--ignore-platform-req phpNote that Travis CI still breaks on PHP 8 because of code coverage, which is not supported for PHP 8 with the current PHPUnit version. I could upgrade PHPUnit to 9.5 (and make the required fixes in tests), but that would mean PHP 7.2 would no longer be supported (PHP 7.3 would be the minimum version).
Perhaps we could leave code coverage out? Or what is your preferred way of handling this?