Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support installation on PHP 8 #70

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

szepeviktor
Copy link
Contributor

No description provided.

@szepeviktor szepeviktor marked this pull request as ready for review May 2, 2021 14:05
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9b21d75 on szepeviktor:patch-2 into 2ecf0eb on mihaeu:main.

@szepeviktor
Copy link
Contributor Author

https://travis-ci.org/github/mihaeu/dephpend/jobs/769221898

  1. Mihaeu\PhpDependencies\Analyser\XDebugFunctionTraceAnalyserTest::testThrowsExceptionIfFileCannotBeOpened

Failed asserting that exception of type "ValueError" matches expected exception "InvalidArgumentException".

Please help me.

@mihaeu
Copy link
Owner

mihaeu commented May 2, 2021

Hey @szepeviktor so you want to both test PHP 8 code and execute dephpend from PHP 8. Makes sense 😅

Before I jump on this: apart from the failing test does everything else seem to work with PHP 8?

@szepeviktor
Copy link
Contributor Author

szepeviktor commented May 2, 2021

Before I jump on this: apart from the failing test does everything else seem to work with PHP 8?

⚠️ I do not have PHP 8 and there is no developer on my side :)

I think there is not. I'm not a dephpend user! Please see https://travis-ci.org/github/mihaeu/dephpend/jobs/769221898

@mihaeu
Copy link
Owner

mihaeu commented May 2, 2021

Even cooler that you're trying to help out 🤗 Cudos! 😎

I figured out the problem, and maybe I'll get around to fixing it tonight. I'll fix it in your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants