Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with packet.id equivalent to zero; check if message id is not None instead of boolean casting #1329

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Fix bug with packet.id equivalent to zero; check if message id is not None instead of boolean casting #1329

merged 1 commit into from
Apr 28, 2024

Conversation

dantetemplar
Copy link
Contributor

@dantetemplar dantetemplar commented Apr 27, 2024 •
edited
Loading

Just check the commit

@miguelgrinberg
Copy link
Owner

miguelgrinberg commented Apr 27, 2024 •
edited
Loading

Out of curiosity, which Socket.IO client or server uses 0 as a callback id?

@miguelgrinberg miguelgrinberg merged commit e593519 into miguelgrinberg:main Apr 28, 2024
18 of 19 checks passed
@dantetemplar
Copy link
Contributor Author

Out of curiosity, which Socket.IO client or server uses 0 as a callback id?

I came across a bug while working with the JS client and msgpack plugin ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dantetemplar @miguelgrinberg