Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .Net 4.5. #411

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

simmdan
Copy link

@simmdan simmdan commented Mar 14, 2019

This PR adds support for .Net 4.5 to TensorFlowSharp. Along the way I converted all of the build projects to the new, much more concise project format which also allows the projects to target multiple frameworks. I also changed the main project to copy the native tensorflow binaries for the current platform to its output directory to make it easier to build and test and added some documentation about how to build and run the tests to the new file BUILD.md.

Unfortunately with these changes 6 of the csharp tests fail, but the same tests fail on all 3 platforms (.net 4.5, .net 4.6 and newer and netstandard 2.0), and I was unable to get all tests to pass before the changes, so I don't think there is a regression.

@simmdan
Copy link
Author

simmdan commented Mar 14, 2019

NOTE: This fixes issue #258.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant