Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with defaults options and some types #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

edausq
Copy link
Contributor

@edausq edausq commented Feb 10, 2017

Default option 'family' is supported only by hash sets except for
hash:mac and default options 'hashsize' and 'maxelem' are supported only
by hash sets. This patch deletes from default_options theses options,
depending to the type name.

This fixes issues when working with some types

# ipset create foo bitmap:port family inet hashsize 1024 maxelem 6553
ipset v6.12.1: Unknown argument: `family'
Try `ipset help' for more information.

According to the man page

family { inet | inet6 }

This parameter is valid for the create command of all hash type sets except for hash:mac.

hashsize

This parameter is valid for the create command of all hash type sets.

maxelem

This parameter is valid for the create command of all hash type sets.

Default option 'family' is supported only by hash sets except for
hash:mac and default options 'hashsize' and 'maxelem' are supported only
by hash sets. This patch deletes from default_options theses options,
depending to the type name.
@edausq
Copy link
Contributor Author

edausq commented May 15, 2017

For information, this patch is in production for several months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant