DNS Update Misc #154
Merged
DNS Update Misc #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Straight up: took a guess and the tests pass.
| } | ||
| u.Ns = make([]RR, 0, len(m)) | ||
| for t := range m { | ||
| u.Ns = append(u.Ns, &ANY{t}) |
There was a problem hiding this comment.
Why the 2-loop approach? You can just as easily wrap for for t := look in the for _, r := range rr one, no?
Also can the copy() function be of use here?
There was a problem hiding this comment.
Yep the second loop could be dropped and replaced with a presence check of the map. copyHeader() should shave off a few lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
71436da needs a closer look since I just took a guess and the tests passed.
104b206 makes
RemoveRRset()work as intended, though I think those update functions shouldn't actually behave the way they do. It makes sense forSetQuestion()to clear the question section, but I don't think the prerequisite and update helpers should clear they're respective sections as stacking a series of prerequisites and changes is likely common.