improved tests and code coverage

Author: Oscar Otero

.gitignore

@@ -1,3 +1,4 @@
 vendor
 composer.lock
 .php_cs.cache
+coverage

CONTRIBUTING.md

@@ -45,3 +45,11 @@ Good pull requests – patches, improvements, new features – are a fantastic h
 ```sh
 composer test
 ```
+
+To get code coverage information execute the following comand:
+
+```sh
+composer coverage
+```
+
+Then, open the `./coverage/index.html` file in your browser.

composer.json

@@ -41,9 +41,10 @@
     },
     "scripts": {
         "test": [
-            "phpunit",
+            "phpunit --coverage-text",
             "phpcs"
         ],
-        "cs-fix": "php-cs-fixer fix ."
+        "cs-fix": "php-cs-fixer fix .",
+        "coverage": "phpunit --coverage-html=coverage"
     }
 }

src/Factory.php

@@ -39,6 +39,7 @@ abstract class Factory
 
     /**
      * Set a custom ResponseFactory.
+     * @codeCoverageIgnore
      */
     public static function setResponseFactory(ResponseFactoryInterface $responseFactory)
     {
@@ -47,6 +48,7 @@ public static function setResponseFactory(ResponseFactoryInterface $responseFact
 
     /**
      * Set a custom StreamFactory.
+     * @codeCoverageIgnore
      */
     public static function setStreamFactory(StreamFactoryInterface $streamFactory)
     {
@@ -55,6 +57,7 @@ public static function setStreamFactory(StreamFactoryInterface $streamFactory)
 
     /**
      * Set a custom UriFactory.
+     * @codeCoverageIgnore
      */
     public static function setUriFactory(UriFactoryInterface $uriFactory)
     {
@@ -63,6 +66,7 @@ public static function setUriFactory(UriFactoryInterface $uriFactory)
 
     /**
      * Set a custom ServerRequestFactory.
+     * @codeCoverageIgnore
      */
     public static function setServerRequestFactory(ServerRequestFactoryInterface $serverRequestFactory)
     {

src/RequestHandlerContainer.php

@@ -10,7 +10,6 @@
 use Psr\Http\Server\RequestHandlerInterface;
 use ReflectionClass;
 use ReflectionMethod;
-use RuntimeException;
 
 /**
  * Resolve a callable using a container.
@@ -50,23 +49,19 @@ public function get($id)
     {
         try {
             $handler = $this->resolve($id);
+
+            if ($handler instanceof RequestHandlerInterface) {
+                return $handler;
+            }
+
+            return new CallableHandler($handler);
+        } catch (NotFoundExceptionInterface $exception) {
+            throw $exception;
         } catch (Exception $exception) {
             throw new class("Error getting the handler $id", 0, $exception)
                 extends Exception implements ContainerExceptionInterface {
             };
         }
-
-        if ($handler instanceof RequestHandlerInterface) {
-            return $handler;
-        }
-
-        if (is_callable($handler)) {
-            return new CallableHandler($handler);
-        }
-
-        throw new class("Handler $id not found or has not valid type", 0, $exception)
-            extends Exception implements NotFoundExceptionInterface {
-        };
     }
 
     /**
@@ -84,10 +79,6 @@ protected function resolve(string $handler)
             return function_exists($handler) ? $handler : $this->createClass($handler);
         }
 
-        if (!is_array($handler) || !is_string($handler[0])) {
-            return $handler;
-        }
-
         list($class, $method) = $handler;
 
         if ((new ReflectionMethod($class, $method))->isStatic()) {
@@ -105,7 +96,9 @@ protected function resolve(string $handler)
     protected function createClass(string $className)
     {
         if (!class_exists($className)) {
-            throw new RuntimeException("The class {$className} does not exists");
+            throw new class("The class $className does not exists")
+                extends Exception implements NotFoundExceptionInterface {
+            };
         }
 
         $reflection = new ReflectionClass($className);
@@ -120,7 +113,7 @@ protected function createClass(string $className)
     /**
      * Slit a string to an array
      *
-     * @return string|array
+     * @return string|string[]
      */
     protected function split(string $string)
     {

tests/ControllerStub.php renamed to tests/Assets/Controller.php

@@ -1,10 +1,14 @@
 <?php
 declare(strict_types = 1);
 
-namespace Middlewares\Tests;
+namespace Middlewares\Tests\Assets;
 
-final class ControllerStub
+final class Controller
 {
+    public static function staticAction()
+    {
+    }
+
     public function action()
     {
     }

tests/Assets/ErrorController.php

@@ -0,0 +1,18 @@
+<?php
+declare(strict_types = 1);
+
+namespace Middlewares\Tests\Assets;
+
+use Exception;
+
+final class ErrorController
+{
+    public function __construct()
+    {
+        throw new Exception('Error Processing Request');
+    }
+
+    public function __invoke()
+    {
+    }
+}

tests/Assets/RequestHandlerController.php

@@ -0,0 +1,15 @@
+<?php
+declare(strict_types = 1);
+
+namespace Middlewares\Tests\Assets;
+
+use Psr\Http\Message\ResponseInterface;
+use Psr\Http\Message\ServerRequestInterface;
+use Psr\Http\Server\RequestHandlerInterface;
+
+final class RequestHandlerController implements RequestHandlerInterface
+{
+    public function handle(ServerRequestInterface $request): ResponseInterface
+    {
+    }
+}

tests/CallableHandlerTest.php

@@ -19,6 +19,19 @@ public function testExecute()
         $this->assertEquals('Hello World', (string) $response->getBody());
     }
 
+    public function testExecuteHandler()
+    {
+        $callable = new CallableHandler(function ($request) {
+            echo $request->getHeaderLine('Foo');
+        });
+
+        $request = Factory::createServerRequest()->withHeader('Foo', 'Bar');
+        $response = $callable->handle($request);
+
+        $this->assertInstanceOf(ResponseInterface::class, $response);
+        $this->assertEquals('Bar', (string) $response->getBody());
+    }
+
     public function testOb()
     {
         $callable = new CallableHandler(function () {

tests/FactoryTest.php

@@ -36,6 +36,20 @@ public function testStream()
         $this->assertTrue($stream->isSeekable());
     }
 
+    public function testStreamWithResource()
+    {
+        $resource = fopen('php://temp', 'r+');
+        fwrite($resource, 'Hello world');
+
+        $stream = Factory::createStream($resource);
+
+        $this->assertInstanceOf(StreamInterface::class, $stream);
+        $this->assertInstanceOf(Stream::class, $stream);
+        $this->assertTrue($stream->isWritable());
+        $this->assertTrue($stream->isSeekable());
+        $this->assertEquals('Hello world', (string) $stream);
+    }
+
     public function testUri()
     {
         $uri = Factory::createUri('http://example.com/my-path');