Merge pull request #4 from shadowhand/fix/allow-header

Send Allow header when method is not allowed
middlewares · Apr 13, 2017 · 6a23e9e · 6a23e9e
2 parents c5f4265 + ca03043
commit 6a23e9e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/FastRoute.php b/src/FastRoute.php
@@ -98,7 +98,7 @@ public function process(ServerRequestInterface $request, DelegateInterface $dele
         }
 
         if ($route[0] === Dispatcher::METHOD_NOT_ALLOWED) {
-            return Factory::createResponse(405);
+            return Factory::createResponse(405)->withHeader('Allow', implode(', ', $route[1]));
         }
 
         foreach ($route[2] as $name => $value) {

diff --git a/tests/FastRouteTest.php b/tests/FastRouteTest.php
@@ -67,6 +67,14 @@ public function testFastRouteNotAllowed()
                     $request->getAttribute('id')
                 );
             });
+
+            $r->addRoute('PUT', '/user/{name}/{id:[0-9]+}', function ($request) {
+                return sprintf(
+                    'Hello %s (%s)',
+                    $request->getAttribute('name'),
+                    $request->getAttribute('id')
+                );
+            });
         });
 
         $request = Factory::createServerRequest([], 'GET', 'http://domain.com/user/oscarotero/35');
@@ -77,6 +85,7 @@ public function testFastRouteNotAllowed()
 
         $this->assertInstanceOf('Psr\\Http\\Message\\ResponseInterface', $response);
         $this->assertEquals(405, $response->getStatusCode());
+        $this->assertEquals('POST, PUT', $response->getHeaderLine('Allow'));
     }
 
     public function testFastRouteResolver()