Fix error when running on Azure Functions #2206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peombwa
reviewed
Aug 1, 2023
src/Authentication/Authentication/Common/GraphSessionInitializer.cs
Outdated
Show resolved
Hide resolved
|
Thanks for your contribution! Can you confirm if you are able to successfully login with the try catch block added - |
|
Welcome! I guess in 99% of scenarios this doesn't change anything. It's pretty rare where the home directory is read-only. As far as I could tell from my testing it appears to work fine on Azure functions in this scenario, and doesn't effect other scenarios. I did only test the function app scenario using managed identity ( |
peombwa
approved these changes
Aug 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2198
Changes proposed in this pull request
The fix for this turned out to be quite simple - just added a try block around the code that attempts to create the graph directory in the user's profile.
As far as I can see this has no flow-on effects. This folder is not used for anything else, other than checking if an existing config file exists. However this step does not fail with the change I have made.
Have tested in Azure Functions ~4, 7.2 runtime.
I also tested in Azure Automation, but this unfortunately does not fix the import error there.