Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ContainsTarget on onenotePage navigation properties #26

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MIchaelMainer
Copy link
Contributor

Closes #25

C# Generation

Generation for navigation properties to a single entity (not in a collection) appears to be setup well. By removing ContainsTarget for this scenario, the existing method call pattern will stay the same:

client.Users[""].Onenote.Pages[""].Request().Expand(x => x.ParentSection).GetAsync();

The difference is that it will be technically a breaking change as client.Users[""].Onenote.Pages[""] will change from returning an IOnenotePageRequestBuilder to a IOnenotePageWithReferencesRequestBuilder. IOnenotePageWithReferenceRequestBuilder enables client.Users[""].Onenote.Pages[""].Reference.Request() which has DeleteAsync() for removing references and PutAsync(string) for adding references. GetAsync(), CreateAsync(), DeleteAsync(), and UpdateAsync() are still available from client.Users[""].Onenote.Pages[""].Request() with this change.

Quick dump. We have an issue when this type of change happens when we remove ContainsTarget=true from navigation properties of collections.

Java generation

TBD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ContainsTarget is not true on these navigation properties
1 participant