Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct admin roles for people admin settings #9512

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

samcheseny
Copy link

New role (People Administrator) was introduced in Entra for tenant settings, updating the docs with it.
Relevant PR: https://msazure.visualstudio.com/One/_git/AD-MSODS-Core/pullrequest/11640921?path=%2Fsrc%2Fdev%2Fidentity%2Fauthz%2FRoleDefinitions%2FroleDefinitions%2FGlobalAdministrator%2FGlobalAdministrator.json
Following the process in https://eng.ms/docs/microsoft-security/identity/entra-developer-application-platform/app-vertical/aad-first-party-apps/identity-platform-and-access-management/role-based-access-control/ship-new-role.


Important

The following guidance is for Microsoft employees only. Community contributors can ignore this message; our content team will manage the status.

After you've created your PR, expand this section for tips and additional instructions.
  • do not merge is the default PR status and is automatically added to all open PRs that don't have the ready to merge label.
  • Add the ready for content review label to start a review. Only PRs that have met the minimum requirements for content review and have this label are reviewed.
  • If your content reviewer requests changes, review the feedback and address accordingly as soon as possible to keep your pull request moving forward. After you address the feedback, remove the changes requested label, add the review feedback addressed label, and select the Re-request review icon next to the content reviewer's alias. If you can't add labels, add a comment with #feedback-addressed to the pull request.
  • After the content review is complete, your reviewer will add the content review complete label. When the updates in this PR are ready for external customers to use, replace the do not merge label with ready to merge and the PR will be merged within 24 working hours.
  • Pull requests that are inactive for more than 6 weeks will be automatically closed. Before that, you receive reminders at 2 weeks, 4 weeks, and 6 weeks. If you still need the PR, you can reopen or recreate the request.

For more information, see the Content review process summary.

@samcheseny
Copy link
Author

@microsoft-github-policy-service agree company="Microsoft"

@samcheseny samcheseny added the ready for content review PR is ready for a content review - content development and tech review are complete. label Feb 10, 2025
@Danielabom Danielabom self-assigned this Feb 11, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot removed the ready for content review PR is ready for a content review - content development and tech review are complete. label Feb 11, 2025
Copy link
Contributor

@Danielabom Danielabom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samcheseny, I approved your PR this time :). But the repo that you should be using is https://github.com/microsoftgraph/microsoft-graph-docs. Regards.

@Danielabom Danielabom added the content review complete Apply when the content review is complete on a PR. label Feb 11, 2025
@samcheseny samcheseny added the ready to merge Use this label to indicate to the repository admins that your PR is ready to merge into master. label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content review complete Apply when the content review is complete on a PR. ready to merge Use this label to indicate to the repository admins that your PR is ready to merge into master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants