Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add site-list.md into sites-and-lists/toc.yml #9458

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

calvin620707
Copy link
Contributor

Important

Required for API changes:

  • Link to API.md file: ADD LINK HERE
  • Link to PR for public-facing schema changes (schema-Prod-beta/v1.0.csdl): ADD LINK HERE

Add other supporting information, such as a description of the PR changes:

I suppose site-list.md should be part of sites-and-lists.


Important

The following guidance is for Microsoft employees only. Community contributors can ignore this message; our content team will manage the status.

After you've created your PR, expand this section for tips and additional instructions.
  • do not merge is the default PR status and is automatically added to all open PRs that don't have the ready to merge label.
  • Add the ready for content review label to start a review. Only PRs that have met the minimum requirements for content review and have this label are reviewed.
  • If your content reviewer requests changes, review the feedback and address accordingly as soon as possible to keep your pull request moving forward. After you address the feedback, remove the changes requested label, add the review feedback addressed label, and select the Re-request review icon next to the content reviewer's alias. If you can't add labels, add a comment with #feedback-addressed to the pull request.
  • After the content review is complete, your reviewer will add the content review complete label. When the updates in this PR are ready for external customers to use, replace the do not merge label with ready to merge and the PR will be merged within 24 working hours.
  • Pull requests that are inactive for more than 6 weeks will be automatically closed. Before that, you receive reminders at 2 weeks, 4 weeks, and 6 weeks. If you still need the PR, you can reopen or recreate the request.

For more information, see the Content review process summary.

Copy link

Learn Build status updates of commit 9ee0ed9:

✅ Validation status: passed

File Status Preview URL Details
api-reference/v1.0/toc/sites-and-lists/toc.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit e4388ce:

⚠️ Validation status: warnings

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@Lauragra
Copy link
Contributor

@calvin620707 , thanks for your contribution. To add methods to the TOC, we link to them in the parent resource topic, and the TOC is then generated. I've updated the PR accordingly.

@Lauragra Lauragra merged commit a3209c2 into microsoftgraph:main Nov 13, 2024
6 of 7 checks passed
Copy link

Learn Build status updates of commit 3206482:

⚠️ Validation status: warnings

File Status Preview URL Details
api-reference/v1.0/resources/site.md ⚠️Warning Details

api-reference/v1.0/resources/site.md

  • Line 1, Column 1: [Warning: title-missing - See documentation] Missing required attribute: 'title'. Add a title string to show in search engine results.
  • Line 9, Column 1: [Warning: h1-not-first - See documentation] Markdown content is not allowed before H1 'site resource type'.
  • Line 1, Column 1: [Suggestion: ms-date-missing - See documentation] Missing required attribute: 'ms.date'.
  • Line 1, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link

Learn Build status updates of commit 302ee8c:

⚠️ Validation status: warnings

File Status Preview URL Details
api-reference/v1.0/api/site-follow.md ⚠️Warning Details
api-reference/v1.0/api/site-unfollow.md ⚠️Warning Details
api-reference/v1.0/resources/site.md ⚠️Warning Details

api-reference/v1.0/api/site-follow.md

  • Line 46, Column 39: [Warning: bookmark-not-found - See documentation] Cannot find bookmark '#id-property' in 'v1.0/resources/site.md'.
  • Line 2, Column 1: [Suggestion: ms-date-missing - See documentation] Missing required attribute: 'ms.date'.

api-reference/v1.0/api/site-unfollow.md

  • Line 46, Column 39: [Warning: bookmark-not-found - See documentation] Cannot find bookmark '#id-property' in 'v1.0/resources/site.md'.
  • Line 2, Column 1: [Suggestion: ms-date-missing - See documentation] Missing required attribute: 'ms.date'.

api-reference/v1.0/resources/site.md

  • Line 0, Column 0: [Warning: h1-missing - See documentation] H1 is required. Use a single hash (#) followed by a space to create your top-level heading.
  • Line 1, Column 1: [Warning: title-missing - See documentation] Missing required attribute: 'title'. Add a title string to show in search engine results.
  • Line 1, Column 1: [Suggestion: ms-date-missing - See documentation] Missing required attribute: 'ms.date'.
  • Line 1, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants