-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format OData cast operationIds #1487
Conversation
Other than the nitpick typo, this LGTM. However, we could accomplish the same by pushing a small change in the conversion lib. See: https://github.com/microsoft/OpenAPI.NET.OData/blob/ef336182076c8a7372af815df71d25d1be04de81/src/Microsoft.OpenApi.OData.Reader/Operation/ODataTypeCastGetOperationHandler.cs#L179 |
Co-authored-by: Irvine Sunday <[email protected]>
Yes, let's tackle that as part of microsoft/OpenAPI.NET.OData#361. All operationIds should be standardized in the conversion lib. |
Kudos, SonarCloud Quality Gate passed! |
Overview
This PR fixes #1228 by ensuring OData cast operationIds are resolved to format that can be interpreted by AutoREST. This is done by merging
[ACTION]
and[AS_CAST_TYPE]
segments on an OData cast operationId. For example:directory.ListDeletedItems.AsApplication
->directory_ListDeletedItemsAsApplication
->Get-MgDirectoryDeletedItemAsApplication
.This PR is a continuation of microsoftgraph/msgraph-metadata#317.
Testing Instructions