Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish symbols #973

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Publish symbols #973

wants to merge 3 commits into from

Conversation

KenitoInc
Copy link
Collaborator

No description provided.

@KenitoInc KenitoInc requested a review from a team as a code owner August 1, 2024 07:09
Copy link

Learn Build status updates of commit 2d092eb:

✅ Validation status: passed

File Status Preview URL Details
.azure-pipelines/ci-build.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

SteveMutungi254
SteveMutungi254 previously approved these changes Aug 1, 2024
Copy link
Contributor

@SteveMutungi254 SteveMutungi254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@MIchaelMainer MIchaelMainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest you add documentation about the existence of the symbols and how a custmer can use it.

displayName: Publish Symbols
inputs:
SymbolsFolder: '$(Build.ArtifactStagingDirectory)'
SearchPattern: '**//Microsoft.Graph.Entra.*.nupkg'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that symbols packages are supposed to have a .snupkg suffix. Maybe that isn't a requirement.

Suggested change
SearchPattern: '**//Microsoft.Graph.Entra.*.nupkg'
SearchPattern: '**//Microsoft.Graph.Entra.*.snupkg'

@MIchaelMainer
Copy link
Contributor

@Ndiritu Can you take a look at this?

@KenitoInc KenitoInc force-pushed the kemunga/Publish-Symbols branch from 2d092eb to 6cb136a Compare September 4, 2024 08:36
Copy link

Learn Build status updates of commit 6cb136a:

✅ Validation status: passed

File Status Preview URL Details
.azure-pipelines/ci-build.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit db8e202:

✅ Validation status: passed

File Status Preview URL Details
.azure-pipelines/ci-build-migrate.yml ✅Succeeded
.azure-pipelines/ci-build.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit f767bfd:

✅ Validation status: passed

File Status Preview URL Details
.azure-pipelines/ci-build-migrate.yml ✅Succeeded
.azure-pipelines/ci-build.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants