Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/New application from template #1346

Merged
merged 4 commits into from
Feb 11, 2025

Conversation

SteveMutungi254
Copy link
Contributor

@SteveMutungi254 SteveMutungi254 commented Feb 10, 2025

Scope:

  • Fixed parity between Beta and GA commands - to use APIs.
  • Added Beta tests - that was missing.
  • Added Beta documentation - that was misleading.
  • Changed parameter name from Id to ApplicationTemplateId and added an alias.

@SteveMutungi254 SteveMutungi254 requested a review from a team as a code owner February 10, 2025 19:39
Copy link

Learn Build status updates of commit 7023030:

💡 Validation status: suggestions

File Status Preview URL Details
module/docs/entra-powershell-beta/Applications/New-EntraBetaApplicationFromApplicationTemplate.md 💡Suggestion View (entra-powershell-beta-preview) Details
module/docs/entra-powershell-v1.0/Applications/New-EntraApplicationFromApplicationTemplate.md 💡Suggestion View (entra-powershell-preview) Details
module/Entra/Microsoft.Entra/Applications/New-EntraApplicationFromApplicationTemplate.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/Applications/New-EntraBetaApplicationFromApplicationTemplate.ps1 ✅Succeeded
test/Entra/Applications/New-EntraApplicationFromApplicationTemplate.Tests.ps1 ✅Succeeded
test/EntraBeta/Applications/New-EntraBetaApplicationFromApplicationTemplate.Tests.ps1 ✅Succeeded

module/docs/entra-powershell-beta/Applications/New-EntraBetaApplicationFromApplicationTemplate.md

  • Line 111, Column 13: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/entra/identity/enterprise-apps/add-application-portal' will be broken in isolated environments. Replace with a relative link.

module/docs/entra-powershell-v1.0/Applications/New-EntraApplicationFromApplicationTemplate.md

  • Line 111, Column 13: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/entra/identity/enterprise-apps/add-application-portal' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@SteveMutungi254 SteveMutungi254 added Ready For Review The PR Ready for Review P0 Highest priority labels Feb 10, 2025
Copy link

Learn Build status updates of commit 8854e8b:

💡 Validation status: suggestions

File Status Preview URL Details
module/docs/entra-powershell-beta/Applications/New-EntraBetaApplicationFromApplicationTemplate.md 💡Suggestion View (entra-powershell-beta-preview) Details
module/docs/entra-powershell-v1.0/Applications/New-EntraApplicationFromApplicationTemplate.md 💡Suggestion View (entra-powershell-preview) Details
module/Entra/Microsoft.Entra/Applications/New-EntraApplicationFromApplicationTemplate.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/Applications/New-EntraBetaApplicationFromApplicationTemplate.ps1 ✅Succeeded
test/Entra/Applications/New-EntraApplicationFromApplicationTemplate.Tests.ps1 ✅Succeeded
test/EntraBeta/Applications/New-EntraBetaApplicationFromApplicationTemplate.Tests.ps1 ✅Succeeded

module/docs/entra-powershell-beta/Applications/New-EntraBetaApplicationFromApplicationTemplate.md

  • Line 111, Column 13: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/entra/identity/enterprise-apps/add-application-portal' will be broken in isolated environments. Replace with a relative link.

module/docs/entra-powershell-v1.0/Applications/New-EntraApplicationFromApplicationTemplate.md

  • Line 111, Column 13: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/entra/identity/enterprise-apps/add-application-portal' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link

Learn Build status updates of commit abcfe70:

💡 Validation status: suggestions

File Status Preview URL Details
module/docs/entra-powershell-beta/Applications/New-EntraBetaApplicationFromApplicationTemplate.md 💡Suggestion View (entra-powershell-beta-preview) Details
module/docs/entra-powershell-v1.0/Applications/New-EntraApplicationFromApplicationTemplate.md 💡Suggestion View (entra-powershell-preview) Details
module/Entra/Microsoft.Entra/Applications/New-EntraApplicationFromApplicationTemplate.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/Applications/New-EntraBetaApplicationFromApplicationTemplate.ps1 ✅Succeeded
test/Entra/Applications/New-EntraApplicationFromApplicationTemplate.Tests.ps1 ✅Succeeded
test/EntraBeta/Applications/New-EntraBetaApplicationFromApplicationTemplate.Tests.ps1 ✅Succeeded

module/docs/entra-powershell-beta/Applications/New-EntraBetaApplicationFromApplicationTemplate.md

  • Line 111, Column 13: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/entra/identity/enterprise-apps/add-application-portal' will be broken in isolated environments. Replace with a relative link.

module/docs/entra-powershell-v1.0/Applications/New-EntraApplicationFromApplicationTemplate.md

  • Line 111, Column 13: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/entra/identity/enterprise-apps/add-application-portal' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@SteveMutungi254 SteveMutungi254 merged commit b308a66 into main Feb 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Highest priority Ready For Review The PR Ready for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants