Populate last_hidden_state in the output of feature extraction model class#863
Merged
Merged
Conversation
vortex-captain
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced from #805
In #805, we removed the last_hidden_state output from the model class output and return whatever output provided by the underlying onnx model.
But this causes a regression. The composite model class
encoder_decoderexpects the encoder model to havelast_hidden_stateoutput. This output is treated as the encoded values. However, some models doesn't have this output name. Therefore, the encoder decoder loop will fail.The fix is to provide last_hidden_state if the underlying onnx model uses a different output name.